Skip to content

chore: Bump Rust version to 1.87.0 and workflow actions #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2025
Merged

chore: Bump Rust version to 1.87.0 and workflow actions #1072

merged 4 commits into from
Jul 9, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 9, 2025 •
edited
Loading

Description

Part of #1018

No changelog entry, as this should only be repo-internal changes.
Lot's of new clippy lints to fix.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer mentioned this pull request Jul 9, 2025
Closed
5 tasks
@sbernauer sbernauer self-assigned this Jul 9, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jul 9, 2025
@Techassi Techassi self-requested a review July 9, 2025 08:09
Techassi
Techassi requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of all these Boxes, but oh well, what can you do. This can only be fixed upstream (if possible at all). I would also like us to bump to Rust 1.88.0 instead.

I left one comment requesting changes. Everything else looks good.

@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jul 9, 2025
@sbernauer
Copy link
Member Author

I would also like us to bump to Rust 1.88.0 instead.

I would prefer that as well, but nixpkgs unstable is currently on 1.87, which is used in make run-dev.
I personally think it's not worth the extra effort to fiddle around with the niv/nixpkgs/crate2nix/whatnot setup.
We can always bump to 1.88 as needed later, unrelated to the SDP release cycle.

We already have a discussion about this in https://stackable-workspace.slack.com/archives/C02FZ581UCD/p1752043094194079?thread_ts=1752042485.505039&cid=C02FZ581UCD

@sbernauer sbernauer requested a review from Techassi July 9, 2025 09:17
@Techassi
Copy link
Member

Techassi commented Jul 9, 2025 •
edited
Loading

@NickLarsenNZ and I decided to move forward with Fenix after the 25.7.0 release. Once that transition is done, we can always bump to the latest available stable Rust version without the need to wait for upstream Nixpkgs.

For now, we can keep it at 1.87.0.

@sbernauer
Copy link
Member Author

Sure, works for me!

Techassi
Techassi approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as is, but we should invest some time on reducing the error sizes down the line. Introducing these Boxes all over the place makes the code harder to read and maintain.

@sbernauer sbernauer added this pull request to the merge queue Jul 9, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Jul 9, 2025
Merged via the queue into main with commit c0ebd1e Jul 9, 2025
8 checks passed
@sbernauer sbernauer deleted the chore/rust-1.87.0 branch July 9, 2025 11:39
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @Techassi